Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep Accelerator Private DNS Zone for "privatelink.*.backup.windowsazure.com" Incorrectly lists uksouth #695

Closed
2 tasks done
jamiepla1 opened this issue Dec 1, 2023 · 2 comments · Fixed by #891
Closed
2 tasks done
Assignees
Labels
Area: Accelerator ⚡ Issues / PR's related to Accelerators Status: In PR 👉 This is when an issue is due to be fixed in an open PR Status: Long Term ⌛ We will do it, but will take a longer amount of time due to complexity/priorities Type: Bug 🪲 Something isn't working

Comments

@jamiepla1
Copy link

What happened? Provide a clear and concise description of the bug, including deployment details.

When using the Accelerator, I used the location default as uksouth

When referencing the file: config\custom-parameters\hubNetworking.parameters.all.json

for the Private DNS Zone "privatelink.*.backup.windowsazure.com", it uses the region name uksouth rather than the geo code uks

e.g it displays: "privatelink.uksouth.backup.windowsazure.com"

rather than

    "privatelink.uks.backup.windowsazure.com",

Please provide the correlation id associated with your error or bug.

xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx

What was the expected outcome?

No response

Relevant log output

No response

Check previous GitHub issues

  • I have searched the issues for this item and found no duplicate

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jamiepla1 jamiepla1 added the bug label Dec 1, 2023
@oZakari
Copy link
Contributor

oZakari commented Dec 4, 2023

Good catch, @jamiepla1! We will update the Accelerator configuration to utilize the geo-codes for this private DNS zone.

@simonhutson
Copy link

The documentation also needs to be updated to reflect the correct geo codes - https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/vwanConnectivity/README.md.

Refer to the following lists for regions codes: https://download.microsoft.com/download/1/2/6/126a410b-0e06-45ed-b2df-84f353034fa1/AzureRegionCodesList.docx

@oZakari oZakari added Status: Long Term ⌛ We will do it, but will take a longer amount of time due to complexity/priorities Area: Accelerator ⚡ Issues / PR's related to Accelerators Type: Bug 🪲 Something isn't working and removed long-term labels Jul 9, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: In PR 👉 This is when an issue is due to be fixed in an open PR label Nov 1, 2024
oZakari pushed a commit that referenced this issue Nov 6, 2024
* accelerator files

* updates to v0.2.0 of ptn

* docs update

* add output for names

* fmt

* bump to pdns 0.2.1

* hub MR changes

* add rel notes draft

* remove pdns module

* doc updates

* update params

* fix psrule

* readme updates

* remove
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accelerator ⚡ Issues / PR's related to Accelerators Status: In PR 👉 This is when an issue is due to be fixed in an open PR Status: Long Term ⌛ We will do it, but will take a longer amount of time due to complexity/priorities Type: Bug 🪲 Something isn't working
Development

Successfully merging a pull request may close this issue.

4 participants