Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Feature Request - Add NSGs to AzureBastionSubnet #240

Closed
BernieWhite opened this issue May 24, 2022 · 0 comments · Fixed by #266
Closed

💡 Feature Request - Add NSGs to AzureBastionSubnet #240

BernieWhite opened this issue May 24, 2022 · 0 comments · Fixed by #266
Assignees
@jtracey93

Comments

@BernieWhite
Copy link
Contributor

BernieWhite commented May 24, 2022 •
edited
Loading

Describe the solution you'd like

Currently hub network modules deploy bastion subnet AzureBastionSubnet without NSGs. The AzureBastionSubnet subnet supports NSGs and it is a Well-Architected Framework (WAF) recommendation to deploy all subnets with NSGs. No specific exclusion applies for AzureBastionSubnet.

Requirements for Bastion NSG is here: https://docs.microsoft.com/azure/bastion/bastion-nsg#nsg

See:

Additional context

This is reported by PSRule for Azure: https://azure.github.io/PSRule.Rules.Azure/en/rules/Azure.VNET.UseNSGs/

Related to #206
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 24, 2022
@BernieWhite BernieWhite mentioned this issue May 24, 2022
Merged
9 tasks
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels May 26, 2022
@jtracey93 jtracey93 mentioned this issue May 27, 2022
Open
@jtracey93 jtracey93 self-assigned this Jun 17, 2022
@jtracey93 jtracey93 mentioned this issue Jun 17, 2022
Merged
9 tasks
jtracey93 added a commit that referenced this issue Jun 20, 2022
@jtracey93
Add NSG to AzureBastionSubnet - Fixing #240 (#266)
90b7027 
* add bastion NSG fixing 💡 Feature Request - Add NSGs to AzureBastionSubnet #240

* reset defaults
@ghost ghost added the Status: Fixed label Jun 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jtracey93 jtracey93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NSG to AzureBastionSubnet - Fixing #240
2 participants
@BernieWhite @jtracey93