Feature/aml managed vnet #43

yogitasrivastava · 2024-04-16T01:22:35Z

Add automation for managed-vnet AML workspace (allow internet outbound) to Azure recipes

...

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

Please follow the test instructions in the Readme.md for test cases.

What to Check

Verify that the following are valid

...

Other Information

Please follow the Readme.md to install the code for automation.

…rkspace.jpg

…rkspace

managed vnet creation template

promisinganuj

More to come!

src/az-aml-managed-vnet/README.md

promisinganuj · 2024-05-05T23:26:35Z

src/az-aml-managed-vnet/README.md

+### Architecture
+
+<!-- Include a high-level architecture diagram of the components used in this recipe. -->
+![architecture](./media/AML_ManagedVNet_Secure_Architecture.png)


Suggest removing the Azure services if they are not deployed as part of the recipe.

Also, suggest using a different font "helvetica" or "tahoma" for the text.

Suggest providing a brief description (few paragraphs) of what's happening in this architecture diagram.

promisinganuj · 2024-05-06T03:19:58Z

src/az-aml-managed-vnet/README.md

+In addition to adding a private endpoint for the AML workspace, a private endpoint should be created for the AML dependant resources such as Azure Blob Storage and Key Vault inside your chosen VNet to enable connectivity to these resources.
+
+### Testing Solution
+To test Azure Machine Learning (AML) end-to-end, you can follow these steps using the **AzureML in a day notebook** from the **Samples** folder within the Notebooks section of Azure Machine Learning:


Where is the notebook? If it's just one notebook, I suggest copying it in the repo and add reference to it. That way, user doesn't have to go to another repo.

Having said that, please feel free to add link to the "AML rep" for reference.

@oloomi Can you pls have a look?

promisinganuj · 2024-05-06T03:22:16Z

src/az-aml-managed-vnet/README.md

+
+In addition to adding a private endpoint for the AML workspace, a private endpoint should be created for the AML dependant resources such as Azure Blob Storage and Key Vault inside your chosen VNet to enable connectivity to these resources.
+
+### Testing Solution


In general, please following the markdown linting rules. For example, leaving spaces before and after the headers. "markdownlint" VS Code extension can help with this.

promisinganuj · 2024-05-06T03:22:57Z

src/az-aml-managed-vnet/README.md

+### Testing Solution
+To test Azure Machine Learning (AML) end-to-end, you can follow these steps using the **AzureML in a day notebook** from the **Samples** folder within the Notebooks section of Azure Machine Learning:
+- Create a Compute Instance:
+  - On the left navigation, select Compute and then Compute Instance. Create a new compute instance and supply a name. Keep all the defaults, expect under networking select No Public IP. Select Review & Create and wait for the deployment to be completed.


Can we add a GIF image to show this?

@oloomi can you please have a look?

promisinganuj · 2024-05-06T03:27:19Z

src/az-aml-managed-vnet/deploy/Terraform/workspace.tf

+  name                     = "sa${random_string.sa_prefix.result}${var.environment}"
+  location                 = azurerm_resource_group.default.location
+  resource_group_name      = azurerm_resource_group.default.name
+  account_tier             = "Standard"


Is there any particular reason for not deploying "ADLS Gen2" account? (is_hns_enabled=true).

@oloomi can you look into it?

promisinganuj · 2024-05-06T04:19:52Z

src/az-aml-managed-vnet/README.md

+  - Sign in to the Azure Machine Learning studio.
+  - Navigate to Notebooks and select the Samples tab.
+  - Look for the AzureML in a day notebook.
+  - Open the notebook and clikc on 'Clone' to create a copy in your workspace file share.


I am getting the following error:

I have already created "blob" PE for the storage account and AKV in the customer VNet.

@oloomi can you pls have a look?

promisinganuj · 2024-05-06T04:29:45Z

Hi @yogitasrivastava / @oloomi / @RenSilvaAU ,

Overall, this is looking really good. Well done!

The recipes in this repo also deploys the "customer VNet" and that's missing from this sample. Suggest you add the following Azure resources:

A customer VNet.
Private Endpoint from storage account to this VNet.
Private Endpoint from key vault to this VNet.
Private Endpoint from AML workspace to this VNet.
Grant get/set access policy on AKV to the deployer.
You would also need to create private DNS Zones for storage, key vault, and AML workspace.

promisinganuj · 2024-05-06T04:35:06Z

Hi @yogitasrivastava / @oloomi / @RenSilvaAU ,

Overall, this is looking really good. Well done!

The recipes in this repo also deploys the "customer VNet" and that's missing from this sample. Suggest you add the following Azure resources:

A customer VNet.

Private Endpoint from storage account to this VNet.

Private Endpoint from key vault to this VNet.

Private Endpoint from AML workspace to this VNet.

Grant get/set access policy on AKV to the deployer.

You would also need to create private DNS Zones for storage, key vault, and AML workspace.

Refer https://github.com/Azure-Samples/virtual-network-integration-recipes/pull/27/files?short_path=64a62a4#diff-64a62a4611883e924d833faeb925f4339bb201c9a3b2df284c1446b9db30f94b for additional guidance. Happy to chat about the details.

Addressed first comment in review

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

mluker · 2024-12-10T21:43:32Z

@yogitasrivastava @oloomi This PR has been stale for a while and has a few unresolved comments. Are we still looking to get this merged in?

yogitasrivastava and others added 30 commits January 9, 2024 16:31

Update recipe-template.md

138f355

Update recipe-template.md

63062ce

Create architecture_managedvnetworkspace.jpg

cde911d

Delete src/az-managed-vnet-workspace/media/architecture_managedvnetwo…

fce3fff

…rkspace.jpg

Create architecture_managedvnetworkspace

0734859

Delete src/az-managed-vnet-workspace/media/architecture_managedvnetwo…

b14f769

…rkspace

Create test

d0e865d

Create test

b99f2de

Delete test

765dc66

Delete src/az-managed-vnet-workspace directory

bb1087a

Create az-managed-vnet-workspace

848a497

Delete src/az-managed-vnet-workspace

924d34d

Create test

e2a2845

Delete src/az-managed-vnet-workspace/media directory

2fbbe33

created aml recipes

13d890e

Update README.md

21d2e41

Add files via upload

5136224

Delete src/az-aml-managed-vnet/recipe-template.md

40ef920

Update README.md

143fd1d

Add files via upload

25ed102

Delete src/az-aml-managed-vnet/deploy/bicep directory

fc0ed4c

Add files via upload

3315b9b

Delete src/az-aml-managed-vnet/media/solution-architecture.png

e36b713

template

338dcf8

managed vnet creation template

Delete src/az-aml-managed-vnet/bicep/test.bicep.txt

d281902

Add files via upload

1a1dc53

Add files via upload

ed199f5

Update README.md

afab950

Delete src/az-aml-managed-vnet/bicep/template.bicep

6d4b464

Update README.md

d790a3c

yogitasrivastava added 5 commits February 28, 2024 13:01

Update README.md

c17f87d

Update README.md

7569010

Update README.md

c9fdff9

Add files via upload

d019f6c

Update README.md

ced173d

yogitasrivastava requested a review from promisinganuj April 16, 2024 01:22

yogitasrivastava assigned yogitasrivastava, RenSilvaAU and oloomi Apr 16, 2024

promisinganuj requested changes May 6, 2024

View reviewed changes

yogitasrivastava and others added 17 commits July 31, 2024 16:35

Update README.md

bdda06e

Addressed first comment in review

Update src/az-aml-managed-vnet/README.md

4787c6a

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

9e3db15

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

99fa4ab

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

517f9d0

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

22ceb73

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

ab2d3cf

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

3415d67

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

00a904f

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

3b44bc6

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

c970e0c

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

8bb176a

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

cde7b73

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

f8b64ac

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

3848473

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

9b8109b

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Update src/az-aml-managed-vnet/README.md

43f82c8

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/aml managed vnet #43

Feature/aml managed vnet #43

yogitasrivastava commented Apr 16, 2024

promisinganuj left a comment

promisinganuj May 5, 2024

promisinganuj May 5, 2024

promisinganuj May 6, 2024

yogitasrivastava Sep 11, 2024

promisinganuj May 6, 2024

promisinganuj May 6, 2024

yogitasrivastava Sep 11, 2024

promisinganuj May 6, 2024

yogitasrivastava Sep 11, 2024

promisinganuj May 6, 2024

yogitasrivastava Sep 11, 2024

promisinganuj commented May 6, 2024 •

edited

Loading

promisinganuj commented May 6, 2024

mluker commented Dec 10, 2024


		In addition to adding a private endpoint for the AML workspace, a private endpoint should be created for the AML dependant resources such as Azure Blob Storage and Key Vault inside your chosen VNet to enable connectivity to these resources.

		### Testing Solution

Feature/aml managed vnet #43

Are you sure you want to change the base?

Feature/aml managed vnet #43

Conversation

yogitasrivastava commented Apr 16, 2024

Add automation for managed-vnet AML workspace (allow internet outbound) to Azure recipes

Does this introduce a breaking change?

Pull Request Type

How to Test

What to Check

Other Information

promisinganuj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

promisinganuj commented May 6, 2024 • edited Loading

promisinganuj commented May 6, 2024

mluker commented Dec 10, 2024

promisinganuj commented May 6, 2024 •

edited

Loading