Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message when mutedByOthers event received #232

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Add message when mutedByOthers event received #232

merged 3 commits into from
Jun 14, 2024

Conversation

allchiang-msft
Copy link
Contributor

Purpose

  • Adds a message bar for a local participant who has been soft muted by another participant.
    image

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • When local participant has been muted by others, a message bar appears

Other Information

fizampou
fizampou reviewed Jun 14, 2024
View reviewed changes
Project/src/MakeCall/CallCard.js Outdated
@@ -262,6 +262,15 @@ export default class CallCard extends React.Component {
}
});

this.call.on('mutedByOthers', () => {
const messageBarText = 'You have been muted by someone else. Unmute to speak.';
console.log(messageBarText);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the console logs please?

@fizampou fizampou merged commit 5d0152c into Azure-Samples:main Jun 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizampou fizampou fizampou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allchiang-msft @fizampou