Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability applied for Reaction API usage #196

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

Mohtasim
Copy link
Contributor

@Mohtasim Mohtasim commented Oct 28, 2023

Purpose

  • Capability read for reaction applied in the API usage for reaction API
  • For not allowed scenario - the API usage would return an error

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • Check for below error message when reaction button is tapped but not allowed in meeting.
Screenshot 2023-11-01 at 8 01 55 PM

Other Information

Signed-off-by: Mohtasim <mbellah@microsoft.com>
Project/src/MakeCall/MakeCall.js Outdated Show resolved Hide resolved
@chriswhilar
Copy link
Contributor

I think the usage pattern is bit wrong cus we are creating extra interfaces that the sdk already has and the interface usage is wrong. Hence its confusing from app perspective. What exactly is the issue and what are we tryin to accomplish?

Signed-off-by: Mohtasim <mbellah@microsoft.com>
Signed-off-by: Mohtasim <mbellah@microsoft.com>
Signed-off-by: Mohtasim <mbellah@microsoft.com>
@Mohtasim Mohtasim merged commit 597ee06 into main Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants