Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CreateFromEnvVars to allow '=' in env var value. #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

briancr-ms
Copy link

Purpose

Fix issue #95. Read environment variables that contain an '=' in the value.

Checklist

  • I have read the contribution guidelines.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the main branch.
    • I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
    • I will squashed my changes into one with a clear description of the change when I complete the PR.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Run MqttConnectionSettings unit tests.

@rido-min
Copy link
Contributor

rido-min commented Mar 6, 2024

we need similar changes to all other languages

@briancr-ms
Copy link
Author

we need similar changes to all other languages

That's reasonable. What's the process for this repo? Do all language changes go into the same PR? Or should I create an issue for each language and resolve these through different PRs?

@rido-min
Copy link
Contributor

rido-min commented Mar 6, 2024

we are updating each sample in different PRs, before creating issues to track I'd like to understand the request. (keep in mind these are regular .env files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants