Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Fix regression in cmake version in codespaces #76

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

vaavva
Copy link
Member

@vaavva vaavva commented Nov 6, 2023

Purpose

  • Codespaces no longer has a new enough version of cmake by default - this adds it to the setup steps. Fixes CMAKE Warning  #70
  • Also fixes a segfault in the getting started sample

Checklist

  • I have read the contribution guidelines.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the main branch.
    • I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
    • I will squash my changes into one with a clear description of the change when I complete the PR.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • ...

What to Check

Verify that the following are valid

  • ...

Other Information

scenarios/getting_started/c/main.c Outdated Show resolved Hide resolved
Copy link
Member

@CIPop CIPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaavva !

@vaavva vaavva merged commit 629dcea into main Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMAKE Warning
2 participants