Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IgnoreEndRevocationUnknown #71

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Use IgnoreEndRevocationUnknown #71

merged 3 commits into from
Oct 31, 2023

Conversation

rido-min
Copy link
Contributor

When validating TLS connections, we dont want to configure the Revocation as NoCheck. Instead, we could use the IgnoreEndRevocationUnknown flag.

Copy link
Member

@CIPop CIPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is reducing security when using CA certificates and that should be:

  1. Clear within the code: comment, function name should be renamed to "Unsafe..."
  2. Audit-ready: a warning-level trace should outline the fact that CA revocation is now disabled.

@rido-min
Copy link
Contributor Author

rido-min commented Oct 27, 2023

I've added traces in fde2823

and also found that we need an additional Ignore flag:

cvArgs.Chain.ChainPolicy.VerificationFlags = X509VerificationFlags.IgnoreEndRevocationUnknown | X509VerificationFlags.IgnoreCertificateAuthorityRevocationUnknown;

I want to investigate more to understand those flags before merging

@rido-min rido-min merged commit 4e785ae into main Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants