Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bb sanitizers on master #9564

Merged
merged 11 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/workflows/bb-msan.yml

This file was deleted.

98 changes: 98 additions & 0 deletions .github/workflows/bb-sanitizers.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
# Checks bb (barretenberg prover library) prover with sanitizers
# Unlike most jobs uses free 4 core github runners of which we have lots of capacity (of total 1000 concurrency).
name: BB MSAN
on:
push:
branches:
- master
- "*/bb-sanitizers*"
pull_request:
types: [opened, synchronize, reopened, labeled]
paths:
- 'barretenberg/**'
workflow_dispatch:
inputs: {}

concurrency:
# force parallelism in master
group: ci-${{ github.ref_name == 'master' && github.run_id || github.ref_name }}
cancel-in-progress: true
jobs:
# acts as prover performance baseline
bb-baseline:
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'bb-msan-check')
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: earthly/actions-setup@v1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- name: "Barretenberg Baseline Performance Check"
run: earthly --no-cache ./barretenberg/cpp/+preset-check --preset=clang16

# memory sanitzer for prover
bb-msan-check:
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'bb-msan-check')
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: earthly/actions-setup@v1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- name: "Barretenberg Prover MSAN Check"

run: earthly --no-cache ./barretenberg/cpp/+preset-msan-check

# address sanitzer for prover
bb-asan-check:
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'bb-asan-check')
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: earthly/actions-setup@v1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- name: "Barretenberg Prover ASAN Check"
timeout-minutes: 720 # 12 hour timeout (proving)
run: earthly --no-cache ./barretenberg/cpp/+preset-check --preset=asan

# address sanitzer for prover
bb-tsan-check:
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'bb-tsan-check')
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: earthly/actions-setup@v1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- name: "Barretenberg Prover TSAN Check"
timeout-minutes: 720 # 12 hour timeout (proving)
run: earthly --no-cache ./barretenberg/cpp/+preset-check --preset=tsan

# undefined behavior sanitzer for prover
bb-ubsan-check:
if: github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'bb-ubsan-check')
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: earthly/actions-setup@v1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
- name: "Barretenberg Prover TSAN Check"
timeout-minutes: 720 # 12 hour timeout (proving)
run: earthly --no-cache ./barretenberg/cpp/+preset-check --preset=ubsan
1 change: 0 additions & 1 deletion .github/workflows/publish-aztec-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ on:
branches:
- master
- "*/release-master*"
- ludamad-patch-2
workflow_dispatch:
inputs:
tag:
Expand Down
10 changes: 9 additions & 1 deletion barretenberg/cpp/Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,15 @@
# install SRS needed for proving
COPY --dir ./srs_db/+build/. srs_db
RUN echo "Warning: If ./bin/client_ivc_tests is not found, there may be build failures above."
RUN cd build && ./bin/client_ivc_tests --gtest_also_run_disabled_tests
RUN cd build && ./bin/client_ivc_tests --gtest_filter="*BasicStructured"

Check failure on line 110 in barretenberg/cpp/Earthfile

View workflow job for this annotation

GitHub Actions / bb-msan-check

Error

The command RUN cd build && ./bin/client_ivc_tests --gtest_filter="*BasicStructured" did not complete successfully. Exit code 1

preset-check:
ARG preset
FROM +source
RUN cmake --preset $preset -Bbuild && cmake --build build --target client_ivc_tests
# install SRS needed for proving
COPY --dir ./srs_db/+build/. srs_db
RUN cd build && ./bin/client_ivc_tests --gtest_filter="*BasicStructured"

Check failure on line 118 in barretenberg/cpp/Earthfile

View workflow job for this annotation

GitHub Actions / bb-tsan-check

Error

The command RUN cd build && ./bin/client_ivc_tests --gtest_filter="*BasicStructured" did not complete successfully. Exit code 66

preset-wasm:
ARG TARGETARCH
Expand Down
Loading