Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolution of bugs from bigfield audits #9547

Merged
merged 36 commits into from
Oct 31, 2024
Merged

fix: Resolution of bugs from bigfield audits #9547

merged 36 commits into from
Oct 31, 2024

Commits on Oct 30, 2024

  1. cmake fix

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7f47f71 View commit details
    Browse the repository at this point in the history

  2. Fix for issue 1 (ZKS.00) "Deduplicating Cached Multiplications Leaves 

    Outputs Unconstrained"
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    d67b760 View commit details
    Browse the repository at this point in the history

  3. Fix for issue 2 (ZKS.02, SPB.3.1.1) Unconstrained exponent

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2babdcd View commit details
    Browse the repository at this point in the history

  4. Fix for issue 3 (ZKS.03, SPB.3.2.1) Unconstrained limbs in exponentia… 

    …tion and issue 15 (ZKS.0a) Handling of constant exponents
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8ffcc6c View commit details
    Browse the repository at this point in the history

  5. Fix for issue 4 (ZKS.01, ZLC.3.4, SPB 3.1.2) Broken bigfield construc… 

    …tor for non-normalized inputs
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7d0c73e View commit details
    Browse the repository at this point in the history

  6. Fix for issue 5 (ZKS.04, ZLC.3.1, ZLC.3.2, SPB3.3.2) Maximum Limb Siz… 

    …e Fails to Ensure Multiplication Soundness
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a8ee595 View commit details
    Browse the repository at this point in the history

  7. Fix for issue 6 (ZKS.05) Broken Bigfield Constructor for Fields of Od… 

    …d Bitlength
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    35b0114 View commit details
    Browse the repository at this point in the history

  8. Fix for issue 7 (ZKS.06, SPB.3.4.1) Swapped Range Constraints on Carries

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0d6d7ed View commit details
    Browse the repository at this point in the history

  9. Fix for issue 8 (ZKS.07, ZLC3.5, ZLC3.6, SPB3.5.6) Unsafe Constructor… 

    …s Allow Breaking Core Invariant
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ceaa933 View commit details
    Browse the repository at this point in the history

  10. Fix for issue 9 (ZLC.3.3) Underflow possible in evaluate_non_native_f… 

    …ield_multiplication
    @Sarkoxed @Rumata888
    Sarkoxed authored and Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9172f9e View commit details
    Browse the repository at this point in the history

  11. Fix for issue 10 (SPB.3.3.1) to_byte_array can have aliases

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    122757e View commit details
    Browse the repository at this point in the history

  12. Fix for issue 11 (ZKS.0b, ZLC.3.7) Proving that multiples of p are un… 

    …equal to 0 modulo p possible
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1c29e5e View commit details
    Browse the repository at this point in the history

  13. Fix for issue 12 (ZKS.09) Maximum High Carry Too Small

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    4ae02d4 View commit details
    Browse the repository at this point in the history

  14. Fix for issue 13 (ZLC.3.8) Equation checks not enforced

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    975290f View commit details
    Browse the repository at this point in the history

  15. Fix for issue 14 (ZLC.3.11) Null-pointer dereference

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    a2ed963 View commit details
    Browse the repository at this point in the history

  16. Fix for issue 16 (ZKS.0e, ZLC.3.12) Handling of max argument to Limb … 

    …constructor
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    202bdf3 View commit details
    Browse the repository at this point in the history

  17. Fix for issue 17 (SPB.3.4.2) Assertion needed to prevent bypass range… 

    …-checks in unsafe_evaluate_multiply_add
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3d2a454 View commit details
    Browse the repository at this point in the history

  18. Fix for issue 19 (ZLC.3.9) Large limbs for constant inputs to conditi… 

    …onal_negate
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    f508f3c View commit details
    Browse the repository at this point in the history

  19. Fix for issue 20 (ZLC.3.10) Incomplete constant check

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8880b4b View commit details
    Browse the repository at this point in the history

  20. Fix for issue 22 (ZLC.3.14) Behavior of assert_equal for constant ope… 

    …rands
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6cf1389 View commit details
    Browse the repository at this point in the history

  21. Fix for issue 23 (ZLC.3.15) Assert for add_to_lower_limb could be ine… 

    …ffective due to overflow
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    0291f09 View commit details
    Browse the repository at this point in the history

  22. Fix for informational issue Missing limb maximum-value check

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    14b006d View commit details
    Browse the repository at this point in the history

  23. Fix for informational issue Equality comparison for null-pointer context

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    707bcc5 View commit details
    Browse the repository at this point in the history

  24. Fix for informational issue Maximum Carry Size Can Underflow 0

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3bfae51 View commit details
    Browse the repository at this point in the history

  25. Fix for informational issue Redundant Normalize (also fixed a soundne… 

    …ss issue in field)
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    edee027 View commit details
    Browse the repository at this point in the history

  26. Fix for informational issue Redundant Bigfield Reduction

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    dd351ff View commit details
    Browse the repository at this point in the history

  27. Fix for informational issue Mixing Constant and Variable Limbs Is Not… 

    … Supported
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e899394 View commit details
    Browse the repository at this point in the history

  28. Fix for informational issue Moduli With 249 Bits Or Less Are Not Supp… 

    …orted
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e1cedf0 View commit details
    Browse the repository at this point in the history

  29. Fix for informational issue Unnecessary duplicated code in assert_equal

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    455a6ca View commit details
    Browse the repository at this point in the history

  30. Fix for informational issue Unnecessary duplicated code

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    52b1c37 View commit details
    Browse the repository at this point in the history

  31. Fix for informational issue Operator overloading for division is dang… 

    …erous
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    105f33f View commit details
    Browse the repository at this point in the history

  32. Fix for informational issue Code duplication in assert_*

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2e0d33f View commit details
    Browse the repository at this point in the history

  33. Fix for informational issue assert_equal with a constant without self… 

    …_reduce could fail. Added comment
    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7bdb3f3 View commit details
    Browse the repository at this point in the history

  34. format fix

    @Rumata888
    Rumata888 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e33472c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. fix

    @Rumata888
    Rumata888 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a695988 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into is/bigfield_fixes_from_3_venodors

    @Rumata888
    Rumata888 authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a728268 View commit details
    Browse the repository at this point in the history