Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Bump puma from 3.12.6 to 4.3.8 #2136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Security] Bump puma from 3.12.6 to 4.3.8 #2136

wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link

@dependabot-preview dependabot-preview bot commented May 18, 2021 •
edited
Loading

Bumps puma from 3.12.6 to 4.3.8. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Keepalive Connections Causing Denial Of Service in puma This vulnerability is related to CVE-2019-16770.

Impact

The fix for CVE-2019-16770 was incomplete. The original fix only protected existing connections that had already been accepted from having their requests starved by greedy persistent-connections saturating all threads in the same process. However, new connections may still be starved by greedy persistent-connections saturating all threads in all processes in the cluster.

A puma server which received more concurrent keep-alive connections than the server had threads in its threadpool would service only a subset of connections, denying service to the unserved connections.

Patches

This problem has been fixed in puma 4.3.8 and 5.3.1.

Workarounds

Setting queue_requests false also fixes the issue. This is not advised when using puma without a reverse proxy, such as nginx or apache, because you will open yourself to slow client attacks (e.g. slowloris).

The fix is very small. A git patch is available here for those using unsupported versions of Puma.

For more information

... (truncated)

Affected versions: <= 4.3.7

Release notes

Sourced from puma's releases.

v4.3.8

  • Security
    • Close keepalive connections after the maximum number of fast inlined requests (#2625)

v4.3.6

puma/puma@v4.3.5...4.3.6

A quick fix for a build error on Mac OS and a JSON require fix for those using phased restart.

  • Explicitly include ctype.h to fix compilation warning and build error on macOS with Xcode 12 (#2304)
  • Don't require json at boot (#2269)

v4.3.0 - Mysterious Traveller

0000492109

Mysterious Traveller

  • Features

    • Strip whitespace at end of HTTP headers (#2010)
    • Optimize HTTP parser for JRuby (#2012)
    • Add SSL support for the control app and cli (#2046, #2052)

  • Bugfixes

    • Fix Errno::EINVAL when SSL is enabled and browser rejects cert (#1564)
    • Fix pumactl defaulting puma to development if an environment was not specified (#2035)
    • Fix closing file stream when reading pid from pidfile (#2048)
    • Fix a typo in configuration option --extra_runtime_dependencies (#2050)

4.2.1

  • 3 bugfixes
    • Fix socket activation of systemd (pre-existing) unix binder files (#1842, #1988)
    • Deal with multiple calls to bind correctly (#1986, #1994, #2006)
    • Accepts symbols for verify_mode (#1222)

4.2.0 - Distant Airhorns

  • 6 features
    • Pumactl has a new -e environment option and reads config/puma/.rb config files (#1885)
    • Semicolons are now allowed in URL paths (MRI only), useful for Angular or Redmine (#1934)
    • Allow extra dependencies to be defined when using prune_bundler (#1105)
    • Puma now reports the correct port when binding to port 0, also reports other listeners when binding to localhost (#1786)
    • Sending SIGINFO to any Puma worker now prints currently active threads and their backtraces (#1320)
    • Puma threads all now have their name set on Ruby 2.3+ (#1968)
  • 4 bugfixes
    • Fix some misbehavior with phased restart and externally SIGTERMed workers (#1908, #1952)
    • Fix socket closing on error (#1941)
    • Removed unnecessary SIGINT trap for JRuby that caused some race conditions (#1961)
    • Fix socket files being left around after process stopped (#1970)
  • Absolutely thousands of lines of test improvements and fixes thanks to @​MSP-Greg

air-horn-sound-s-econd-air-horn-sound-me-this-23916124

... (truncated)

Changelog

Sourced from puma's changelog.

4.3.8 / 2021-05-11

  • Security
    • Close keepalive connections after the maximum number of fast inlined requests (#2625)

4.3.7 / 2020-11-30

  • Bugfixes
    • Backport set CONTENT_LENGTH for chunked requests (Originally: #2287, backport: #2496)

4.3.6 / 2020-09-05

  • Bugfixes
    • Explicitly include ctype.h to fix compilation warning and build error on macOS with Xcode 12 (#2304)
    • Don't require json at boot (#2269)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
[Security] Bump puma from 3.12.6 to 4.3.8
35e2ef4 
Bumps [puma](https://github.com/puma/puma) from 3.12.6 to 4.3.8. **This update includes a security fix.**
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v3.12.6...v4.3.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels May 18, 2021
@dependabot-preview
Copy link
Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2140, which may be blocking Dependabot from updating your dependency files.

@dependabot-preview
Copy link
Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2144, which may be blocking Dependabot from updating your dependency files.

@dependabot-preview
Copy link
Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2147, which may be blocking Dependabot from updating your dependency files.

@dependabot-preview
Copy link
Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2156, which may be blocking Dependabot from updating your dependency files.

@dependabot-preview
Copy link
Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2158, which may be blocking Dependabot from updating your dependency files.

@dependabot-preview
Copy link
Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2165, which may be blocking Dependabot from updating your dependency files.

@dependabot-preview
Copy link
Author

Dependabot tried to update this pull request, but something went wrong. The most likely cause is #2172, which may be blocking Dependabot from updating your dependency files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants