Use new stats layout in budget stats #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
add_district_stats_to_polls
branch
from
33b5e37 to
47123a4
Compare
javierm
force-pushed
the
add_district_stats_to_polls
branch
7 times, most recently
from
65ac5aa to
3427ca2
Compare
javierm
changed the title
javierm
force-pushed
the
add_district_stats_to_polls
branch
from
3427ca2 to
48e266c
Compare
decabeza
force-pushed
the
add_district_stats_to_polls
branch
from
48e266c to
b1bf370
Compare
It was only defined in the custom routes file.
So now stats by gender and age are replaced by shared participation stats (which also includes stats by district), reusing the code already used in poll stats, and advanced statistics (which used to be at the top of the page) are now displayed after partipation stats.
We were using custom translations, but now this code is going to be included in the main CONSUL repository.
Data equalizer was used to show a border to separate sidebar from the content. Now is the same with only css avoiding use js.
decabeza
force-pushed
the
budget_stats
branch
from
ca79dae to
08031c6
Compare
microweb10
approved these changes
Feb 11, 2019
This was referenced Mar 18, 2019
This was referenced Apr 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Use the poll stats layout in budget stats.
Does this PR need a Backport to CONSUL?
Yes, backport when backporting everything related to stats.
Notes
statsand rebase if necessary once Add advanced stats to polls #1789 is merged