Honeypot on users sign up form #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Changes honeypot
:family_nameto:addresson users sign up form. This prevent a real user fill this honeypot hidden field when use "autofill" browser feature.We use
HTML <input> autocomplete = "off"in some fields in this form (honeypot included) but it seems new browsers are ignoring this value.Visual Changes
The honeypot field is hidden but I change styles to show it and view the changes
BEFORE
AFTER
Does this PR need a Backport to CONSUL?
Backport to CONSUL.
Notes
Some info about HTML autocomplete = "off":
HTML autocomplete Attribute
AutoComplete=Off” not working on Google Chrome Browser
Chrome ignores autocomplete=“off”