Update of admin/stats/budget_balloting calculus method #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raul-fuentes
force-pushed
the
update_stats
branch
3 times, most recently
from
31d1f67 to
eee4c43
Compare
raul-fuentes
changed the title
raul-fuentes
force-pushed
the
update_stats
branch
4 times, most recently
from
b59e328 to
2945ffc
Compare
raul-fuentes
force-pushed
the
update_stats
branch
from
2945ffc to
e60a787
Compare
aitbw
force-pushed
the
update_stats
branch
2 times, most recently
from
ad3086c to
6823f0b
Compare
the stats/budget are calculated on the fly, this method require about 10/20 seconds with 350000 votes and 4000 users
the orders which retrieves the data are now written with arel instead of sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#1472
Objectives
Change the statistics page admin/budget_balloting. The statistics are now calculated on the fly.
Visual Changes
None
Notes
Here can be seen some screenshots showing the performance of the proposed change
the db numbers
the time needed to response
the actual html output
I strongly recommend use 'intersect' as soon as it becomes available on Active Record, or if it is necessary that the page be faster you can use sql (it is not very canonical but it improves the efficiency)