-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pam authentication #273
Pam authentication #273
Conversation
I just thought, this should probably made async. Depending on the pam configuration, there may be a delay when authentication fails. This will currently freeze ags for that time (I didn't test this though). |
It definitely needs to be async yes |
I noticed an issue with this, which is quite easy fixable, I'm just writing this here to remember it. This will create a libpam.so library in the libdir. The default libdir currently is /usr/lib, so this will overwrite the libpam.so file of the Pam package, and therefore breaking pam. |
I think its fine, Gvc is also installed there, and we didn't get any feedback about it being an issue |
Well actually, there was a complaint on discord a few month ago, because gvc installs to /usr/lib/libgvc.so which conflicts with the graphviz package. That's the reason why the aur package has the --libdir parameter set to /usr/lib/ags. This is only an issue if installed from source following the instructions on the wiki, as there the libdir is set to /usr/lib. So if someone does not know about this and follows the wiki for manual installation ends up with a broken pam install (as Pam is installed on almost every system). This should be avoided. Maybe at least add the --libdir parameter to meson in the wiki then.
If you are talking about the input inhibitor Wayland protocol, that's been deprecated for a while now. For lockscreens the ext-session-lock protocol should be used. |
Adds methods to Utils to be able to authenticate against Pam.
Note:
This is the first time I wrote a gir lib and it's been a long time since I used C, so it might be a good idea to check this a bit more in detail.