Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to customize Kafka Event Publisher Processing Group name via properties #444

Conversation

aupodogov
Copy link
Contributor

When using Kafka Token Store with common topic for storing tokens from many applications the ability to distinguish processing groups from each application is needed. This can be done by manually configure KafkaEventPublisher with a lot of code. This PR adds ability to specify processing group name via properties.

Copy link

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small improvements. Otherwise looks good. I do wonder how you use/like the token store.

@aupodogov
Copy link
Contributor Author

aupodogov commented Sep 7, 2023

I do wonder how you use/like the token store.

We're just doing our first proof of concept adapter application that do two way integration with external app via Kafka (and store tokens in Kafka topic). The idea of storing tokens right into Kafka topic is very promising!

@aupodogov aupodogov requested a review from gklijs September 7, 2023 11:40
Copy link

@gklijs gklijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gklijs gklijs merged commit a8fd46c into AxonFramework:master Sep 7, 2023
@gklijs gklijs self-assigned this Sep 7, 2023
@gklijs gklijs added this to the Release 4.8.1 milestone Sep 7, 2023
@aupodogov aupodogov deleted the kafka-event-publisher-processing-custom-processing-group-name branch September 7, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants