Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a code smell I created earlier. #298

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix a code smell I created earlier. #298

merged 1 commit into from
Jun 17, 2022

Conversation

gklijs
Copy link

@gklijs gklijs commented Jun 17, 2022

Makes it more explicit an exception should have been thrown. As it was one of the few code smells I could not resist fixing it.

@gklijs gklijs added this to the Release 4.6.0 milestone Jun 17, 2022
@gklijs gklijs requested a review from smcvb June 17, 2022 09:21
@gklijs gklijs self-assigned this Jun 17, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smcvb
smcvb approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gklijs gklijs merged commit 3925555 into master Jun 17, 2022
@gklijs gklijs deleted the fix_code_smell branch June 17, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

Assignees

@gklijs gklijs

Labels
Priority 2: Should Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gklijs @smcvb