Fix issue 260 by adding a topic function. #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gklijs
force-pushed
the
feature260
branch
6 times, most recently
from
0ee2824 to
ad92584
Compare
|
Tried to make the test setup more similar to framework, but still I have |
|
Integration tests failing, should break the build now, and total coverage is reported again. |
smcvb
reviewed
Mar 30, 2022
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
...framework/extensions/kafka/eventhandling/producer/DefaultProducerFactoryIntegrationTest.java
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
…since build succeeded with failing integration tests, and coverage report was missing.
smcvb
requested changes
Mar 31, 2022
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/TopicResolver.java
Show resolved
Hide resolved
...a/src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/TopicResolver.java
Show resolved
Hide resolved
...a/src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/TopicResolver.java
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
...a/src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/TopicResolver.java
Outdated
Show resolved
Hide resolved
…ndling/producer/KafkaPublisher.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
…ndling/producer/KafkaPublisher.java Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
smcvb
reviewed
Mar 31, 2022
...a/src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/TopicResolver.java
Outdated
Show resolved
Hide resolved
smcvb
reviewed
Mar 31, 2022
...a/src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/TopicResolver.java
Show resolved
Hide resolved
smcvb
approved these changes
Mar 31, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue 260 by adding a topic function. Refactor how test are run, since build succeeded with failing integration tests, and coverage report was missing.
Fixes #260