Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sonar issues, either by improving the code, or by suppressing the warning. #256

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix sonar issues, either by improving the code, or by suppressing the warning. #256

merged 1 commit into from
Mar 11, 2022

Conversation

gklijs
Copy link

@gklijs gklijs commented Mar 10, 2022

Fix sonar issues, either by improving the code, or by suppressing the warning.
fixes #254

@gklijs gklijs added this to the Release 4.6.0 milestone Mar 10, 2022
@gklijs gklijs requested review from smcvb and lfgcampos March 10, 2022 12:47
@gklijs gklijs self-assigned this Mar 10, 2022
smcvb
smcvb approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

...n/java/org/axonframework/extensions/kafka/eventhandling/producer/DefaultProducerFactory.java Outdated Show resolved Hide resolved
@gklijs gklijs force-pushed the fix_sonar_issues branch from d6a3dbd to 4e7953a Compare March 10, 2022 15:17
@gklijs gklijs force-pushed the fix_sonar_issues branch from 4e7953a to ac89019 Compare March 10, 2022 15:18
smcvb
smcvb reviewed Mar 11, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think this looks fine! :-)

@gklijs gklijs merged commit 88f74c4 into master Mar 11, 2022
@gklijs gklijs deleted the fix_sonar_issues branch March 11, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@lfgcampos lfgcampos Awaiting requested review from lfgcampos

Assignees

@gklijs gklijs

Labels
Priority 2: Should Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

Go through Sonar issues and either improve the code, or ignore the issue.
2 participants
@gklijs @smcvb