Added properties to disable autoconfiguration for publishing and consuming events to/from Kafka #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uming events to/from Kafka
|
|
smcvb
requested changes
Feb 2, 2022
There was a problem hiding this comment.
Thanks for this, @aupodogov! I have a couple of pointers though:
- I am missing tests for this change.
- This is a feature. As such, it should point to the
masterbranch, making it a part of 4.6.0 - It would be helpful to add these boolean properties to the
KafkaPropertiesclass. Doing so allows JavaDoc documentation to pop up in the property files too. Added, it's a great place for default values instead of the annotation.
Other than that, thanks for the quick effort here, @aupodogov!
smcvb
approved these changes
Feb 3, 2022
...ing-boot-autoconfigure/src/main/java/org/axonframework/extensions/kafka/KafkaProperties.java
Outdated
Show resolved
Hide resolved
...ing-boot-autoconfigure/src/main/java/org/axonframework/extensions/kafka/KafkaProperties.java
Outdated
Show resolved
Hide resolved
...gure/src/main/java/org/axonframework/extensions/kafka/autoconfig/KafkaAutoConfiguration.java
Outdated
Show resolved
Hide resolved
# Conflicts: # kafka-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/kafka/autoconfig/KafkaAutoConfiguration.java
|
@smcvb can we point this change to 4.5.x to release earlier? |
|
Switching the branch to merge with won't work anymore due to the changes this branch will bring to 4.5.x. So, instead, I'll go about cherry-picking your changes from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR add ability to disable autoconfiguration publishing and consuming events to/from Kafka via properties
axon.kafka.publisher.enabledandaxon.kafka.fetcher.enabled