Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AxParameter library from native SDK #64

Closed
wants to merge 1 commit into from
Closed

Use AxParameter library from native SDK #64

wants to merge 1 commit into from

Conversation

deepikas20
Copy link
Contributor

@deepikas20 deepikas20 commented Mar 20, 2024 •
edited
Loading

Describe your changes

Using axparameter library from ACAP native SDK.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@deepikas20 deepikas20 requested a review from a team as a code owner March 20, 2024 13:50
@deepikas20 deepikas20 changed the title Use axparameter from native SDK Use AxParameter library from native SDK Mar 20, 2024
madelen-at-work
madelen-at-work requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@madelen-at-work madelen-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
You should base this against main branch, we want to get it in already there (however it will not be merged until after we do a last LTS compatible release)
Also - do not refer to JIRA tickets in the commit messages
The same goes for docker-compose-acap

@madelen-at-work madelen-at-work added the after_LTS merge after LTS release label Mar 21, 2024
@deepikas20 deepikas20 changed the base branch from rootless_shadow to main March 21, 2024 15:48
@madelen-at-work
Copy link
Contributor

cherry-picked from docker-acap - closing this PR

@madelen-at-work madelen-at-work deleted the use-native-sdk-axparameter branch April 4, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelen-at-work madelen-at-work madelen-at-work requested changes

Assignees
No one assigned
Labels
after_LTS merge after LTS release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepikas20 @madelen-at-work