Skip to content

Commit

Permalink
Log missing TLS certificates as a warning rather than an error (#153)
Browse files Browse the repository at this point in the history
TLS is enabled by default and uploading certificates over HTTP needs to
happen after the application has started, so the user cannot avoid this
message when using HTTP rather than SSH.

The warning message already exists in tls_log_missing_cert_certs(),
so this change only removes the generic error message at the call site.

Co-authored-by: Mattias Axelsson <mattiaax@axis.com>
  • Loading branch information
github-actions[bot] and killenheladagen authored Apr 30, 2024
1 parent c05e796 commit af679d6
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions app/dockerdwrapperwithcompose.c
Original file line number Diff line number Diff line change
Expand Up @@ -412,12 +412,8 @@ static bool read_settings(struct settings* settings, const struct app_state* app
// when TCP won't be used. If the setting is changed we will loop through
// this function again.
settings->use_tls = false;
else {
if (!get_and_verify_tls_selection(param_handle, &settings->use_tls)) {
log_error("Failed to verify tls selection");
return false;
}
}
else if (!get_and_verify_tls_selection(param_handle, &settings->use_tls))
return false;

settings->use_ipc_socket = is_parameter_yes(param_handle, PARAM_IPC_SOCKET);

Expand Down

0 comments on commit af679d6

Please sign in to comment.