Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for setting proxy #252

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Add documentation for setting proxy #252

merged 8 commits into from
Jul 3, 2024

Conversation

Stiv-work
Copy link
Contributor

@Stiv-work Stiv-work commented Jun 13, 2024 •
edited
Loading

Document setting proxy

  • Check developer mode link is valid, before merging in.

@Stiv-work
Add dockumentation for setting proxy
385a037 
Change-Id: I0ad7263cfc4921059dda637014308a3ba6630360
@Stiv-work Stiv-work requested review from a team as code owners June 13, 2024 12:07
@Stiv-work Stiv-work changed the title Add dockumentation for setting proxy Add documentation for setting proxy Jun 13, 2024
killenheladagen
killenheladagen reviewed Jun 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Stiv-work
Update for received comments
4c32125 
Change-Id: I309da850391a4a20e6170f2515f2f4ba6a97ce37
@Stiv-work
wip
2bc5e95 
Change-Id: I70d9c7643f9cd042ca4579a16328abf3badbe24f
madelen-at-work
madelen-at-work reviewed Jun 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
madelen-at-work
madelen-at-work reviewed Jun 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
madelen-at-work
madelen-at-work reviewed Jun 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
madelen-at-work
madelen-at-work reviewed Jun 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Stiv-work
Resolving comments
4d52b91 
Change-Id: I61abdb32e48586dd5a4007989e4d4c85f3100443
@Stiv-work
lint
eb7030d 
Change-Id: I17cf6325fbfda3f9ebaf71f6b259f37535186d75
killenheladagen
killenheladagen reviewed Jun 20, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
madelen-at-work
madelen-at-work reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@madelen-at-work madelen-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the text is ok now but we need to wait for the Developer Mode section in the documentation

pataxis
pataxis reviewed Jul 3, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Stiv-work
update to comments
ae2a8f0 
Change-Id: I537672ab8be0eeec902a7c9a3c8212a67e370998
@Stiv-work
Update Developer Mode doc link
9be95f8 
Change-Id: I4d8e3939dca7a65285aca26227a25120770fc43e
@Stiv-work Stiv-work merged commit e5a937f into main Jul 3, 2024
13 checks passed
@Stiv-work Stiv-work deleted the document_proxy branch July 3, 2024 11:09
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killenheladagen killenheladagen killenheladagen left review comments

@pataxis pataxis pataxis approved these changes

@madelen-at-work madelen-at-work madelen-at-work approved these changes

Assignees

@killenheladagen killenheladagen

@madelen-at-work madelen-at-work

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stiv-work @killenheladagen @pataxis @madelen-at-work