Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added guidance when an incorrect character is entered #92

Conversation

ICTEnablers
Copy link
Collaborator

No description provided.

@ICTEnablers ICTEnablers requested a review from duff92 November 5, 2019 15:14
Copy link
Collaborator

@duff92 duff92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggested changes above, otherwise I think it looks good :)

src/components/task/task.tsx Outdated Show resolved Hide resolved
src/components/task/task.tsx Outdated Show resolved Hide resolved
src/components/task/task.tsx Outdated Show resolved Hide resolved
src/config/utils.ts Outdated Show resolved Hide resolved
src/config/utils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@arethsu arethsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from comments, I'm also getting an error when running the application. It complains about an undefined variable textToSpeak on line 249.

@ICTEnablers ICTEnablers merged commit a9ef17a into develop Nov 6, 2019
@arethsu arethsu deleted the feature/74-Add-better-feedback-for-finger-placement-in-task-component branch November 6, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants