Feature/94 clean up code in task after audio testing #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…play to finish. Put play of first letter in task in to separate useEffect, previously it tried to play for each letter. Fixed handling of undefined promise in audio.tsx
duff92
requested changes
Nov 7, 2019
src/components/task/task.tsx
Outdated
| correctAudioElement.current.load(); | ||
| wrongAudioElement.current.load(); | ||
|
|
||
| audioElement.current) { |
src/components/task/task.tsx
Outdated
| if (correctAudioElement.current) { | ||
| correctAudioElement.current.setAttribute('currentTime', '0'); | ||
| correctAudioElement.current.play().then(() => { | ||
| if(correctKeyPressed) { |
src/components/task/task.tsx
Outdated
| } | ||
| }).catch(error => console.error('play current error', error)); | ||
| } | ||
| else { |
There was a problem hiding this comment.
else should be placed on same line
} else {
src/components/task/task.tsx
Outdated
| }, [currentPos, task.exercise, ttsOptions]); | ||
|
|
||
| useEffect(() => { | ||
| speak(task.exercise[currentPos].text, ttsOptions).then(url => playAudio(audioElement, url)); |
There was a problem hiding this comment.
Add catch for playAudio and speak
src/components/audio/audio.tsx
Outdated
|
|
||
| const promise = audio.current.play(); | ||
| if (promise !== undefined) { | ||
| const promise = audio.current.play().catch(error => console.error('playAudio error '+error)); |
There was a problem hiding this comment.
Add spaces in string console.error('playAudio error ' + error)
duff92
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to merge this before the sprint demo