refactor(demo) more hook and storybook #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div className={className}> | ||
| <div className="container-fluid container af-title-bar__wrapper"> | ||
| {backHome && ( | ||
| <Link title="Retour à l'accueil" className="btn af-btn--circle" to="/"> |
There was a problem hiding this comment.
why you don't use Link router component ?
There was a problem hiding this comment.
It was not working inside my stories ^^
I generaly Never use it.
There was a problem hiding this comment.
you just have to wrap your story by a Router
i think you also create global decorator
| const withCustomFetch = fetch => Component => props => { | ||
| console.log(fetch,props.environment, Component ); | ||
| const withCustomFetch = fetch => Component => ({environment, ...otherProps}) => { | ||
| console.log(fetch, environment, Component ); |
| }; | ||
|
|
||
| export default withCustomFetch(fetch)(HomeContainer); | ||
| export default withCustomFetch(fetch)(withRouter(HomeContainer)); |
There was a problem hiding this comment.
composition should be more readable
samuel-gomez-axa
approved these changes
Sep 25, 2019
| const items = await fetchDevis(fetch)(); | ||
| setState({ | ||
| loading: false, | ||
| items: items |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.