Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactor , possible breaking change for eventNames.token_aquired rename #1422

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Minor refactor , possible breaking change for eventNames.token_aquired rename #1422

merged 3 commits into from
Jul 22, 2024

Conversation

jafin
Copy link
Contributor

@jafin jafin commented Jul 21, 2024

  • fix spelling token_acquired
  • refactor(parameters): Default parameters should be last.sonarlint(typescript:S1788)
  • refactor(initWorker): null coalescing

this will be a breaking change if consumers reference eventNames.token_aquired

@jafin jafin changed the title Minor refactor Minor refactor , possible breaking change for eventNames.token_aquired rename Jul 21, 2024
@jafin jafin force-pushed the task/refactor-minor branch from d0da364 to 1659f07 Compare July 21, 2024 22:03
guillaume-chervet
guillaume-chervet approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@guillaume-chervet guillaume-chervet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @jafin

@guillaume-chervet guillaume-chervet merged commit 6b5f6b4 into AxaFrance:main Jul 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaume-chervet guillaume-chervet guillaume-chervet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafin @guillaume-chervet