Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not concatenate empty dataframes #949

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Do not concatenate empty dataframes #949

merged 1 commit into from
Jan 10, 2025

Conversation

dachengx
Copy link
Collaborator

Otherwise, you will see

/home/xudc/strax/strax/run_selection.py:196: FutureWarning: The behavior of DataFrame concatenation with empty or all-NA entries is deprecated. In a future version, this will no longer exclude empty or all-NA columns when determining the result dtypes. To retain the old behavior, exclude the relevant entries before the concat operation.
  docs = pd.concat([docs, new_docs[~np.in1d(new_docs["name"], docs["name"])]], sort=False)

@coveralls
Copy link

Coverage Status

coverage: 88.913%. remained the same
when pulling d207e4c on no_merge_empty
into 2ded3e0 on master.

@dachengx dachengx marked this pull request as ready for review January 10, 2025 20:44
@dachengx dachengx merged commit 6ee25af into master Jan 10, 2025
8 checks passed
@dachengx dachengx deleted the no_merge_empty branch January 10, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants