Remove NotImplementedError for multi_output in DownChunkingPlugin #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some discussions about this. As a reference: #769 (comment) |
|
Hey @HenningSE . Is this still needed? |
|
If we go with the Truth plugins as they are right now in the PR: no. |
|
We are still able to reopen this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Right now it is not possible to have a DownChunkingPlugin with multiple outputs. I would like to add truth information handling in fuse and for that I need a second output in the PMTResponseAndDAQ plugin.
Can you briefly describe how it works?
The PR just removes the
NotImplementedError.Can you give a minimal working example (or illustrate with a figure)?
It was necessary to change how the PMTResponseAndDAQ yields its results a bit but I found no problems running the fuse simulations with the implemented changes. The corresponding fuse PR can be found here: XENONnT/fuse#99.