Adds HV into dispatcher #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
approved these changes
Sep 16, 2021
Comment on lines
+46
to
+50
| try: | ||
| commit = subprocess.run('git log -n 1 --pretty=oneline'.split(), capture_output=True).stdout.decode().split(' ')[0] | ||
| except Exception as e: | ||
| logger.debug(f'Couldn\'t get commit hash: {type(e)}, {e}') | ||
| commit = 'unknown' |
There was a problem hiding this comment.
Could use https://github.com/XENONnT/daqnt/pull/79/files as well (also for related packages like daqnt)
There was a problem hiding this comment.
We could, but now that the biggest part of daqnt is here, the only things from daqnt that we still use are the logger, the bot, and the Mongo Client. I think it's much more important that we have a strict and accurate version for the dispatcher and hypervisor because these things affect uptime, while the bot and logger don't. Also the dispatcher isn't a module, and I don't see much reason to change this.
Co-authored-by: Joran Angevaare <jorana@nikhef.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the HV is now integral to the dispatcher, and the HV doesn't really have any sensitive info in it, makes little sense to have them separate.
Also the dispatcher now logs its commit hash, for precise version tracking.