Add support for Avalonia 0.11. #4
Conversation
| @@ -7,7 +7,6 @@ | |||
| </Application.DataTemplates> | |||
|
|
|||
| <Application.Styles> | |||
| <FluentTheme Mode="Light"/> | |||
There was a problem hiding this comment.
Did you start demo app? I sure what nothing will be rendered without styles
| <TextBlock Grid.Column="2" Grid.Row="0" HorizontalAlignment="Center" Text="AdvancedImage"/> | ||
| <TextBlock Grid.Column="3" Grid.Row="0" HorizontalAlignment="Center" Text="Image"/> |
There was a problem hiding this comment.
I thing what moving controls content is an unnecessary change, not related to compatibility with avalonia 11
There was a problem hiding this comment.
In the latest Avalonia 0.11 version. They are not going to support putting text like
<TextBlock>xxx</TextBlock> # This will throw the errorAs a result, we have to put all the texts in the Text property.
| @@ -69,7 +69,7 @@ public class AdvancedImage : ContentControl { | |||
|
|
|||
| var loaderChangedObservable = LoaderProperty.Changed | |||
| .Where(args => args.IsEffectiveValueChange) | |||
| .Where((args, i) => i == 0 || args.Sender.GetValue(ShouldLoaderChangeTriggerUpdateProperty)) | |||
| .Where((args, i) => i == 0 || (bool)args.Sender.GetValue(ShouldLoaderChangeTriggerUpdateProperty)) | |||
There was a problem hiding this comment.
This change will trigger possible null reference exception warning. We should suppress it via adding ! to the end of expression
|
I can implement it by myself tomorrow, if you want |
|
I just did a quick fix for those issues. Everything should be fine right now! |
|
Temporarily, I will merge them in a separate branch, and post the Avalonia 11 package myself (in a short time) |
|
Hello, @laolarou726 |
This change added support for Avalonia 0.11-beta-001.