Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ObjectDisposedException in Cancellation token access (#19) #20

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix ObjectDisposedException in Cancellation token access (#19) #20

merged 1 commit into from
Sep 25, 2023

Conversation

ionite34
Copy link
Contributor

Changes:

  • ignore ObjectDisposed exceptions during canceling of oldCancellationToken
  • no longer dispose oldCancellationToken since it may be being used in another call
  • instead we dispose the token source the current method created in a finally clause of the task

@ionite34 ionite34 mentioned this pull request Sep 25, 2023
Closed
SKProCH
SKProCH approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@SKProCH SKProCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks!

@SKProCH SKProCH merged commit 7c543ab into AvaloniaUtils:master Sep 25, 2023
@SKProCH
Copy link
Member

SKProCH commented Sep 25, 2023

I will publish a new version the next day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SKProCH SKProCH SKProCH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ionite34 @SKProCH