Add .UseReactiveUI() call to xplat template

[schnerring]

I was studying the templates and found that xplat is missing the .UseReactiveUI() call.

Related:

• MVVM template is missing UseReactiveUI in AppBuilder. #19
• Added call to .UseReactiveUI. #20

[schnerring]

My change shouldn't break the iOS build, however I don't have an environment where I can test this.

[Takoooooo]

PR makes sense. Will check later why does IOS fails

[maxkatz6]

I don't think ReactiveUI is compatible with iOS of current SDK. It definitely wasn't couple of months ago.

[Gillibald]

I vote against this change because it introduces a dependency that isn't really required

[maxkatz6]

In this case PackageReference should be removed as well. It's just unused now.

[schnerring]

In this case PackageReference should be removed as well. It's just unused now.

It's not unused. The reference to ReactiveUI could be removed, but it would still be referenced implicitly through the AvaloniaTest project reference. AvaloniaTest uses the Avalonia.ReactiveUI package.

[schnerring]

My understanding from comparing the templates is that the project generated from the app-mvvm template and the AvaloniaTest project from the xplat template are functionally the same - both MVVM ReactiveUI projects. Except that platform-specific code was separated from AvaloniaTest into other projects.

My change just consolidates one of the small differences between these projects.

[maxkatz6]

Build should work with latest reactiveui (18.0.7+) reactiveui/ReactiveUI#3184

[schnerring]

Cool!

Do we wait until you bump the version in:

https://github.com/AvaloniaUI/Avalonia/blob/master/build/ReactiveUI.props#L3

I could also push a commit referencing 18.0.7+ explicitly.

[Takoooooo]

Try merging master to the branch now,i assume it was an issue on our side and i will later think about whether it is a good idea to merge this.

[maxkatz6]

Btw, this call was added only to Desktop call. But not to other projects.
I.e. it should be something like this in AppDelegate for iOS:

protected override AppBuilder CustomizeAppBuilder(AppBuilder builder)
{
    return base
        .CustomizeAppBuilder(builder)
        .UseReactiveUI();   
}

It's not unused. The reference to ReactiveUI could be removed, but it would still be referenced implicitly through the AvaloniaTest project reference

It's unused in actual xplat template. Makes sense to add, but main repo should update reactiveUI to 18.x before that.

[maxkatz6]

Merging as we didn't have time to remove ReactiveUI from the default xplat template.