Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Code Analysis issues for C# templates #229

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Fixes Code Analysis issues for C# templates #229

merged 4 commits into from
Aug 14, 2023

Conversation

curia-damiano
Copy link
Contributor

In my project I have enabled code analysis and found a couple of issues.
I would like to contribute updating the templates to benefit everyone.

@Takoooooo
Copy link
Contributor

I guess these problems apply to F# templates too,may you add these fixes for them also?

@curia-damiano
Copy link
Contributor Author

I'm sorry but I really don't know F#...

@Mrxx99
Copy link
Contributor

Mrxx99 commented Aug 2, 2023

I don't think waring suppressions should be in code, that just adds noise and most don't use analyzers that report these. What could maybe make sense is to set the "mark members as static" as ignored in the csproj. As this almost always reports wrongly on ViewModels

@Mrxx99
Copy link
Contributor

Mrxx99 commented Aug 2, 2023

There are also some indentation changes that look wrong

@Takoooooo
Copy link
Contributor

Generally i am ok with everything besides identation changes,can they be reverted? I will add these changes to F# templates after that

@curia-damiano
Copy link
Contributor Author

sorry I use tabs on my machine. I will work on this later

@curia-damiano
Copy link
Contributor Author

About the Gretting variable, another option is to make it static, but probably this would change the meaning of the view model.

Or it can returns some non-static string

@Takoooooo
Copy link
Contributor

@curia-damiano ping

@curia-damiano
Copy link
Contributor Author

I've fixed the formatting

@Takoooooo Takoooooo merged commit 778879f into AvaloniaUI:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants