Return view locator #203
Merged
Return view locator #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
reviewed
Jun 13, 2023
| @@ -91,6 +91,13 @@ | |||
| "defaultValue": "true", | |||
| "isEnabled": "(AvaloniaVersion != \"0.10.21\")" | |||
| }, | |||
| "RemoveViewLocator": { | |||
| "type": "parameter", | |||
| "description": "Defines if your app will use default ViewLocator made by Avalonia Team or you are planning to use custom one. Removing ViewLocator may be useful in AOT scenarios. Default ViewLocator is not AOT-friendly.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Defines if your app will use default ViewLocator made by Avalonia Team or you are planning to use custom one. Removing ViewLocator may be useful in AOT scenarios. Default ViewLocator is not AOT-friendly.", | |
| "description": "Defines if your app will use default ViewLocator made by Avalonia Team or you are planning to use a custom one. Removing ViewLocator may be useful in code trimming scenarios. Default ViewLocator is not trimming-friendly.", |
Here and in other places too.
I would suggest disabling this property by default in 11.0 version, but I am tired to argue about view-locator.
There was a problem hiding this comment.
do you mean enabling? It is already disabled by default
There was a problem hiding this comment.
Yeah, enabling "--remove-view-locator". Or disabling view locator in other words.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.