Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No conditions in AXAML files #191

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Mrxx99
Copy link
Contributor

@Mrxx99 Mrxx99 commented Apr 20, 2023

Removes all conditions in AXAML files (App.axaml) because the used syntax is not supported anymore with newer .NET SDK (currently latest preview), as it was changed to support the XML comment syntax as it is for XAML files. The new syntax can't be used here yet, as users may still have older .NET SDKs.

Additional context:
dotnet/templating#6409

I guess only after .NET 6 or 7 is out of support the conditions (with the new syntax) can be used again in AXAML files.

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun

@maxkatz6 maxkatz6 merged commit af3b6aa into AvaloniaUI:master Apr 20, 2023
@Mrxx99 Mrxx99 deleted the feature/no-conditions-in-axaml branch June 15, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants