Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nuget restore post actions #159

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

Mrxx99
Copy link
Contributor

@Mrxx99 Mrxx99 commented Jan 13, 2023

This adds a nuget restore post action to the project templates.
It is currently not added for the xplat templates because there the experience is not great if you do not have all the workloads installed as e.g. Android, iOS and web fail

CLI output

grafik

I wanted to specifiy that only the shared and Desktop project should be restored, but there seems to be a bug in templating so this does not work (dotnet/templating#5922).

We could already merge it without the xplat templates if you want and add the xplat templates later, when the issue is fixed in the SDK.

@Takoooooo
Copy link
Contributor

Works good,but i am curious why this parameter isn't displayed in the CLI and it isn't displayed in the VS? Also may you add it to the readme because otherwise people wouldn't ever know it exists

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Jan 16, 2023

Added the option to the readme.
It is displayed in CLI:
grafik
And in VS it is not displayed because it is not added to the ide.host.json what was intentional as the nuget restore post action is ignored by IDEs (at least VS) as you can read here: https://github.com/dotnet/templating/wiki/Post-Action-Registry#restore-nuget-packages

@Takoooooo
Copy link
Contributor

LGTM,thanks!

@Takoooooo Takoooooo merged commit bd899f8 into AvaloniaUI:master Jan 17, 2023
@Mrxx99 Mrxx99 deleted the feature/restore-post-action branch June 15, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants