Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post action: opening main files in editor #153

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

Mrxx99
Copy link
Contributor

@Mrxx99 Mrxx99 commented Jan 6, 2023

This adds primary outputs and post actions to open the most relevant files in editor when the template is used in VS or Rider.
Depending on the template type it will open the following files after creating a project:
app: MainWindows.axaml, MainWindow.axaml.(cs|fs) (this is the same as the WPF templates)
app-mvvm: MainWindow.axaml, MainWindowViewModel.(cs|fs)
xplat: MainView.axaml, MainViewModel.(cs|fs)

Note: somehow it does not open the .axaml files for F# projects on Rider, on VS everything works fine.

The WPF and the other dotnet sdk project templates have besides this open in editor action also the nuget restore action.
Should we add this as well? (They also have a --no-restore parameter for CLI)

Off topic: I noticed Rider does not support custom template parameters at all currently, so choosing avalonia version or MVVM toolkit does not work (only target framework is supported)

@grokys grokys requested a review from Takoooooo January 10, 2023 11:15
@Takoooooo
Copy link
Contributor

Adding nuget restore action makes sense for me also!

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Jan 10, 2023

@Takoooooo also with --no-restore flag?
Should I add this to this PR or open a new one?

@Takoooooo
Copy link
Contributor

--no-restore

Not sure what do you mean by --no-restore flag,i don't see that in the template.json.
Add that to the separate PR

@Takoooooo
Copy link
Contributor

Also please answer on the question in the comments to the previous PR
#154 (comment)

@Takoooooo
Copy link
Contributor

LGTM,thanks for doing that!

@Takoooooo Takoooooo merged commit f7312ca into AvaloniaUI:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants