Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MVVM choice for F# MVVM template #149

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

Mrxx99
Copy link
Contributor

@Mrxx99 Mrxx99 commented Dec 29, 2022

This adds the same choice for MVVM framework that the C# MVVM template has to F#.
Fixes #108

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Dec 29, 2022

@Takoooooo Is there a specific reason why ReactiveUi uses a additonal ViewModelBase class and CommunityToolkit does not? It would simplify the templates if this would be uniform.

@Takoooooo
Copy link
Contributor

@Takoooooo Is there a specific reason why ReactiveUi uses a additonal ViewModelBase class and CommunityToolkit does not? It would simplify the templates if this would be uniform.

Makes sense,probably. I will merge this PR and we can do that in the separate one

@Mrxx99
Copy link
Contributor Author

Mrxx99 commented Jan 3, 2023

Makes sense,probably. I will merge this PR and we can do that in the separate one

Ok, to what should we uniform? That ViewModelBase is used for all or that it is not used at all?

@Takoooooo
Copy link
Contributor

Takoooooo commented Jan 5, 2023

Makes sense,probably. I will merge this PR and we can do that in the separate one

Ok, to what should we uniform? That ViewModelBase is used for all or that it is not used at all?

Let's leave ViewModelBase for both

@Takoooooo
Copy link
Contributor

Takoooooo commented Jan 5, 2023

LGTM,thanks! Also at this point i assume we may close this issue as fixed.

@Takoooooo Takoooooo merged commit d855248 into AvaloniaUI:master Jan 5, 2023
@Mrxx99 Mrxx99 deleted the feature/mvvmtoolkit-for-fsharp branch January 5, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make templates fully usable from VS
2 participants