Change F# xplat web project to use .NET 7 wasm #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takoooooo
reviewed
Dec 13, 2022
|
Otherwise LGTM i think |
|
Also i have added project for you,seems we have not that many stuff to do before 11.0 |
|
@Takoooooo There seems to be a problem with the build pipeline as it now failed for both PRs but works locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me the current F# web project created with the xplat template does not work (it just never finishes loading).
So I changed it to the same way the C# project was updated to (removing blazor).
This works for me, but note I am not experienced at F# and don't know the best practices and did not do further testing apart from starting the project generated with the template (which now works), so it would be good if someone with F# experience takes a look. Therefore I marked it as draft.