Avalonia version choice for MVVM templates #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takoooooo
approved these changes
Dec 7, 2022
|
If you are happy to proceed helping us with this i may create a project board where i will note everything that we need to do to make our templates fully usable from VS without extension. |
|
@Takoooooo Yes, I am happy to proceed helping here, the board sound like a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds also Avalonia version choice to the MVVM templates and simplifies the choosing for all.
With the old way it would be nested
#ifs for the MVVM templates.With the new way the version has also now only to be specified for the choices and not again in the csproj files.
If the simplified way is not liked I can also revert to the old
#if/ #elseifsyntax, so only the change that the Avalonia version is added to the MVVM templates remains (first commit).