Fix --no-build publishing when axaml compiler is used

[js6pak]

What does the pull request do?

Fixes dotnet publish --no-build when axaml compiler is used.

What is the current behavior?

The original assembly before axaml compilation is copied resulting in the following crash:
Unhandled exception. Avalonia.Markup.Xaml.XamlLoadException: No precompiled XAML found for AvaloniaApplication1.App, make sure to specify x:Class and include your XAML file as AvaloniaResource

What is the updated/expected behavior with this PR?

The proper assembly is copied over, and the application starts correctly.

How was the solution implemented (if it's not obvious)?

I've used ComputeResolvedFilesToPublishList because that's where IntermediateAssembly and _DebugSymbolsIntermediatePath are processed.
An alternative solution is prepending InjectAvaloniaXamlOutput to PublishItemsOutputGroupDependsOn Turns out even that won't work because ComputeAndCopyFilesToPublishDirectory would end up calling ComputeResolvedFilesToPublishList before PublishItemsOutputGroup.
Adding PublishItemsOutputGroup to InjectAvaloniaXamlOutput's BeforeTargets won't work because it will run after ComputeResolvedFilesToPublishList.

Repro

rm -rf bin obj && dotnet build -c Release && dotnet publish --no-build && ./bin/Release/net8.0/publish/AvaloniaApplication1

[avaloniaui-bot]

You can test this PR using the following package version. 11.2.999-cibuild0051519-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[cla-avalonia]

• All contributors have signed the CLA.

[js6pak]

@cla-avalonia agree

[TomEdwardsEnscape]

LGTM

[maxkatz6]

Thank you!

[ahsan136]

Thank you!

How do I implement this fix? I am having the same issue

[MattSturgeon]

How do I implement this fix? I am having the same issue

Here's how we backported the fix in nixpkgs: https://github.com/NixOS/nixpkgs/blob/ae8a436bc79e20e05d16f4df99aae01527602f0f/pkgs/build-support/dotnet/fetch-nupkg/overrides.nix#L45-L47

If you're getting Avalonia from nuGet, you can do something similar by substituting or patching build/AvaloniaBuildTasks.targets and buildTransitive/AvaloniaBuildTasks.targets;

replacing 'BeforeTargets="CopyFilesToOutputDirectory;BuiltProjectOutputGroup"'
with 'BeforeTargets="CopyFilesToOutputDirectory;BuiltProjectOutputGroup;ComputeResolvedFilesToPublishList"'.

[ahsan136]

I made the changes as suggested for nuGet, however after publishing the application I still run into the same exception:
Exception Info: Avalonia.Markup.Xaml.XamlLoadException: No precompiled XAML found for App.App, make sure to specify x:Class and include your XAML file as AvaloniaResource

[MattSturgeon]

I'm not too familiar with how this works outside of nixpkgs. It sounds like the Avalonia you're patching isn't the one being used after your app is published.

Maybe something like "self contained build" will help?

[ahsan136]

I added the following but still getting the same error? Also I am on Avalonia version 11.1.3.

	<PropertyGroup>
		<RuntimeIdentifier>win-x86</RuntimeIdentifier>
		<PlatformTarget>x86</PlatformTarget>
		<SelfContained>true</SelfContained>
	</PropertyGroup>

[TomEdwardsEnscape]

You can get the fix by updating to 11.2.0-beta2