Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimpleTheme for TimePicker #16758

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

VisualMelon
Copy link
Contributor

What does the pull request do?

Fixes #16743

What is the current behaviour?

TimePicker crashes under the SimpleTheme

What is the updated/expected behaviour with this PR?

TimePicker no longer crashes

How was the solution implemented (if it's not obvious)?

Removes a duplicate part definition in TimePicker's SimpleTheme control template

Checklist

  • Added unit tests (if possible)?
    • No added tests, but I'm happy to add additional tests with guidance
  • Added XML documentation to any related classes?
    • No changes warranting documentation
  • Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

No breaking changes

Obsoletions / Deprecations

No Obsoletions or Deprecations

Fixed issues

Fixes #16743

@maxkatz6 maxkatz6 added the bug label Aug 22, 2024
@VisualMelon
Copy link
Contributor Author

Anything else needed from me?

@cla-avalonia
Copy link
Collaborator

cla-avalonia commented Sep 2, 2024

  • All contributors have signed the CLA.

@VisualMelon
Copy link
Contributor Author

@cla-avalonia agree

@maxkatz6 maxkatz6 merged commit add5ef0 into AvaloniaUI:master Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimePicker crashes under Simple Theme in 11.2.0-beta1
3 participants