Fixes geometry render bounds when curves are present #16756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes the render bounds of geometries containing curves.
What is the current behavior?
The render bounds are too large, containing the curve control points.
Example:
At the top is
DrawingImage
with incorrect bounds, having the height almost twice as high as necessary.At the bottom is a
Path
with correct bounds (Path
has its own bounds calculation).Show code
Geometry:
What is the updated/expected behavior with this PR?
The bounds are correctly computed.
Result:
How was the solution implemented (if it's not obvious)?
SKPath.TightBounds
is used instead ofSKPath.Bounds
.(These were the only two usages of
Bounds
, other types usingSKPath
were already usingTightBounds
.)A unit test has been added.
Note that an existing unit test has been modified, because it used round line caps, which caused the same problem.