Fix - Grow datagrid height if there's available space #16527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
added
bug
area-datagrid
backport-candidate-11.1.x
maxkatz6
requested changes
Aug 1, 2024
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
grokys
added
the
customer-priority
grokys
approved these changes
Aug 2, 2024
grokys
pushed a commit
that referenced
this pull request
Oct 8, 2024
Co-authored-by: Max Katz <maxkatz6@outlook.com>
grokys
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Allows DataGrid to grow vertically with items added, if there's available space. Height can still be constrained by Height and MaxHeight properties, or by parent size.
What is the current behavior?
Currently, DataGrid permanently sets content height on the first row layout pass, to the total height of the rows. If items count increases, a scrollbar appears and extra items are hidden. This occurs even if there's enough space to grow in the parent
What is the updated/expected behavior with this PR?
DataGrid no longer estimates the row cells height, as it's now provided by the parent on measure pass.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #8771