Fixes #16346 #16347
Merged
Fixes #16346 #16347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
maxkatz6
added
bug
backport-candidate-11.1.x
|
@cla-avalonia agree |
|
You can test this PR using the following package version. |
grokys
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR prevents recycled elements from being used as anchors by
ScrollContentPresenterin the case that those elements have not been arranged beforeEnsureAnchorElementSelectionis called.What is the current behavior?
Currently, emitting a
Resetevent causes items to be recycled without removing them as anchor candidates. This causes the incorrect element to be selected as an anchor element when arrangingScrollContentPresenter. This incorrect anchor element is then interpreted as a change in offset, causing theScrollViewerto scroll more than intended.What is the updated/expected behavior with this PR?
This can be tested with the following sample repository.
https://github.com/mpylon/ava-virtualization/tree/master
Fixed issues
Fixes #16346