Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NuGet packages to Avalonia v11.1.1 #179

Merged
merged 6 commits into from
Aug 4, 2024

Conversation

DamianSuess
Copy link
Collaborator

@DamianSuess DamianSuess commented Aug 3, 2024

Details

  • Upgrade Avalonia NuGet packages to v11.1.1
  • Fixed ItemsControlRegionAdapter

Linked To Issue/Feature

Tests

  • Basic functional tests
  • View Discovery - Region view transitions
  • Sample MVVM App - Generic bindings, regions, journal navigation, notifications, MVVM.
  • Sample Dialog App - Ability to create modal and non-modal dialog system
  • Bootstrapper Shell
  • Modules App - Ability to create modules and support regions

@DamianSuess DamianSuess added enhancement New feature or request Avalonia-v11.0.x Avalonia v11.0.x labels Aug 3, 2024
@DamianSuess DamianSuess added this to the Prism 9.0.x milestone Aug 3, 2024
@DamianSuess DamianSuess self-assigned this Aug 3, 2024
@DamianSuess DamianSuess linked an issue Aug 3, 2024 that may be closed by this pull request
@DamianSuess
Copy link
Collaborator Author

Currently testing

@DamianSuess
Copy link
Collaborator Author

DamianSuess commented Aug 3, 2024

Issue found in ModulesSampleApp where ItemsControlRegionAdapter is already bound. Using the same region adapter from SampleMvvmApp causes a module to not register its events quick enough.

Prism.Navigation.Regions.RegionCreationException

An exception occurred while creating a region with name 'ListRegion'. The exception was: System.InvalidOperationException: ItemsControl's ItemsSource property is not empty.

This control is being associated with a region, but the control is already bound to something else. 
If you did not explicitly set the control's ItemSource property, 
this exception may be caused by a change in the value of the inherited RegionManager attached property.

@DamianSuess DamianSuess added the Prism-v9.0.x-pre Prism v9.0.x Pre-Release label Aug 3, 2024
@DamianSuess DamianSuess marked this pull request as draft August 4, 2024 00:20
…revious binding reference. Updated Module/Event sample app, addressing the ItemsControlRegionAdapter.
@DamianSuess DamianSuess marked this pull request as ready for review August 4, 2024 01:32
@DamianSuess
Copy link
Collaborator Author

Ready to roll baby!

"WOOO!!" - Ric Flair

@DamianSuess DamianSuess merged commit be313b1 into develop Aug 4, 2024
@DamianSuess DamianSuess deleted the feature/PrismAvalona-11.1 branch August 4, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Avalonia-v11.0.x Avalonia v11.0.x enhancement New feature or request Prism-v9.0.x-pre Prism v9.0.x Pre-Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Avalonia v11.1 (pre-release)
1 participant