-
Notifications
You must be signed in to change notification settings - Fork 70
Conversation
BREAKING CHANGE: moment has been replaced
Deploy preview for availity-reactstrap-validation ready! Built with commit fbc7b66 https://deploy-preview-126--availity-reactstrap-validation.netlify.com |
I don't think this is a breaking change. We don't expose the underlying date library. It doesn't change the API this library exposes or it's usage/results. If someone is depending on something without it being in their owns deps... then that is their fault. |
For some reason availity-reactstrap-validation/__test__/AvValidator.date.spec.js Lines 69 to 71 in 897a4af
availity-reactstrap-validation/__test__/AvValidator.date.spec.js Lines 45 to 47 in 897a4af
Passing in Not sure why this is happening but I am going to open an issue on |
Created issue here: iamkun/dayjs#555 |
BREAKING CHANGE: moment has been replaced
All of the existing tests that cover the date validation work. The only downside is that we will have to release as a
BREAKING CHANGE
since some users can rely uponmoment
in other areas of their projects since its a required dep here.closes #125