Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto lint code with cargo fmt #381

Merged
merged 6 commits into from
Jul 7, 2023
Merged

auto lint code with cargo fmt #381

merged 6 commits into from
Jul 7, 2023

Conversation

v9n
Copy link
Member

@v9n v9n commented Jul 6, 2023

This is just a utility github action to auto run cargo fmt and if detect changes due to auto format, it will commit the change to the same branch, thus avoid us need to run this manually or having setup a git hooks locally to catch this.

it helps to simplify the code because the repeated work about re-runing cargo fmt can be outsource to the CI without relying on a local editor setup to auto run, or manual run.'

It looks like this in practice. The fixup:... one is the auto format commit run in this action
Screenshot 2023-07-06 at 12 03 16 AM

@v9n v9n self-assigned this Jul 6, 2023
@v9n v9n requested a review from chrisli30 July 6, 2023 07:07
Copy link
Member

@chrisli30 chrisli30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it looks good. Let’s set it up.

@v9n v9n merged commit 6946450 into master Jul 7, 2023
@v9n v9n deleted the auto-lint-with-cargo-fmt branch August 9, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants