Set/Validate/escape these parameters in the settings page #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid XSS by validating and escape these parameters on the settings page. The XSS is on an admin-only page so impact is low. Also set the ossdl_https index to avoid a php warning on the CDN tab.
kraftbj
pushed a commit
that referenced
this pull request
Feb 9, 2017
* Don't delete so many files on blogs with static homepages. #175 * Discourage use of file locking because semaphores cause problems and it's not needed. #174 * Reorganise the settings page in small ways #173 * Fixed XSS in settings page. Props @jaypatel #172 git-svn-id: http://plugins.svn.wordpress.org/wp-super-cache/trunk@1587563 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid XSS by validating and escape these parameters on the settings
page. The XSS is on an admin-only page so impact is low. Only an
admin user can set it.
Also set the ossdl_https index to avoid a php warning on the CDN tab.